-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (defer): deferred fragment condition evaluation #353
fix (defer): deferred fragment condition evaluation #353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This behavior is still wrong I think. If the conditions evaluate to false
, the fragment will still be executed, it just won't be deferred. We need to treat it as a non-deferred fragment in that case, not ignore it completely.
Yes, you're right. 🤦♂️ I'll correct this when I'm back on Monday. |
@AnthonyMDev this is now fixed with an additional test to ensure that a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now! Minor suggestions on the implementation, but the functionality is correct.
Co-authored-by: Anthony Miller <anthonymdev@gmail.com>
ea6311c
into
feature/defer-execution-networking
Conditions on a deferred fragment were not correctly being evaluated during field collection. This meant that deferred fragments would always be collected into
_deferredFragments
regardless of any condition. It's now fixed and deferred fragments are not collected if the condition would evaluate to false meaning the deferred fragment should never be expected to be received.